villebro commented on a change in pull request #11233:
URL:
https://github.com/apache/incubator-superset/pull/11233#discussion_r504534034
##########
File path: superset/db_engine_specs/__init__.py
##########
@@ -49,3 +49,8 @@
and attribute.engine != ""
):
engines[attribute.engine] = attribute
+
+ # populate engine alias name to engine dictionary
+ if isinstance(attribute.engine_aliases, tuple) and
attribute.engine_aliases:
+ for engine_alias in attribute.engine_aliases:
+ engines[engine_alias] = attribute
Review comment:
This can probably be simplified as follows:
```suggestion
# populate engine alias name to engine dictionary
for engine_alias in attribute.engine_aliases or []:
engines[engine_alias] = attribute
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
