adam-stasiak commented on pull request #11254: URL: https://github.com/apache/incubator-superset/pull/11254#issuecomment-708631103
> Is this a re-work of #11254? Just trying to figure out if this needs to be thoroughly reviewed again, or if it's the same stuff, split out. I'd still honestly rather just finish up the prior one, if it's all the same. Not sure if you or others have feelings on this. I fixed review findings and splitted change related to attribute from #11134 into this PR and next I will submit test code using these attributes. It will be easier now when this will be merged - smaller changes then I think. Please for green light for this and merging to avoid conflicts - real blocker for me in pushing forward. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
