rusackas commented on a change in pull request #11254:
URL:
https://github.com/apache/incubator-superset/pull/11254#discussion_r504942973
##########
File path: superset-frontend/src/components/FaveStar.tsx
##########
@@ -46,7 +46,12 @@ export default class FaveStar extends
React.PureComponent<FaveStarProps> {
label="fave-unfave"
tooltip={t('Click to favorite/unfavorite')}
>
- <a href="#" onClick={this.onClick} className="fave-unfave-icon">
+ <a
+ href="#"
+ onClick={this.onClick.bind(this)}
Review comment:
this is a very strange place to see a `bind` - if this needs to happen,
pease do it in the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
