nytai commented on a change in pull request #11254:
URL:
https://github.com/apache/incubator-superset/pull/11254#discussion_r504948119
##########
File path: superset-frontend/src/components/dataViewCommon/TableCollection.tsx
##########
@@ -272,6 +276,7 @@ export default function TableCollection({
const rowId = row.original.id;
return (
<tr
+ data-test="table-row"
Review comment:
hmm, how would we automate testing production/staging releases? I don't
think these are really adding much bloat in the grand scheme of things. Data
test attributes should be unique though, so I'd suggest changing this to
`table-row-${i}` where i is the row number, so it's easier to select the nth row
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
