adam-stasiak commented on a change in pull request #11254:
URL:
https://github.com/apache/incubator-superset/pull/11254#discussion_r504949205
##########
File path: superset-frontend/src/components/dataViewCommon/TableCollection.tsx
##########
@@ -272,6 +276,7 @@ export default function TableCollection({
const rowId = row.original.id;
return (
<tr
+ data-test="table-row"
Review comment:
I was thinking about this but finally decided to left this as table-row
and logic related to choosing proper element move to cypress code using
children() and eq() syntax. What do you think? which option is more valuable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
