rusackas commented on a change in pull request #11216:
URL:
https://github.com/apache/incubator-superset/pull/11216#discussion_r505859764
##########
File path: superset-frontend/src/SqlLab/components/QuerySearch.jsx
##########
@@ -39,6 +39,15 @@ const propTypes = {
displayLimit: PropTypes.number.isRequired,
};
+const TableStyles = styled.div`
+ height: ${props => props.height};
Review comment:
Not sure if it's too much to tackle this in this PR (we can create an
Issue/ticket if it is), but I would LOVE to stop passing heights/widths around
as props (not just here, but all over the codebase), and start using things
like flexbox layouts to tackle these issues. It would reduce a lot of rendering
and increase performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
