rusackas commented on a change in pull request #11216:
URL:
https://github.com/apache/incubator-superset/pull/11216#discussion_r505861092
##########
File path: superset-frontend/src/SqlLab/components/QuerySearch.jsx
##########
@@ -278,9 +287,9 @@ class QuerySearch extends React.PureComponent {
{this.state.queriesLoading ? (
<Loading />
) : (
- <div
+ <TableStyles
className="scrollbar-content"
- style={{ height: this.props.height }}
+ height={this.props.height}
Review comment:
This line shouldn't be needed, as it's covered in the `styled`
implementation. But just to reiterate, I'd love to not need this prop at all :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]