villebro opened a new pull request #11325: URL: https://github.com/apache/incubator-superset/pull/11325
### SUMMARY Adds support for `applied_filters` and `rejected_filters` to chart data endpoint + adds support for temporal extras to both `viz.py` and chart data endpoint. Short summary of changes: - In the legacy data `json_explore` endpoint, temporal extras (`__time_range` etc) are applied to `form_data` in `merge_extras` (see: https://github.com/apache/incubator-superset/blob/735123d1f5513d366955db1865faf6b064c9bd4a/superset/utils/core.py#L922-L953 ), information of which temporal filters have been overridden is lost. To get around this, we add the applied temporal extras in a dict called `applied_time_extras` that we can later reference to determine which of them were applied and which were not. - since `superset-ui/core` merges temporal extras to the query object prior to sending the request, essentially performing the above operation (see: https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-core/src/query/extractExtras.ts) , we need to pass along `applied_time_extras` in the request. ### TEST PLAN CI with updated old tests + new E2E test ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
