villebro commented on a change in pull request #11325:
URL:
https://github.com/apache/incubator-superset/pull/11325#discussion_r507538247
##########
File path: superset/charts/schemas.py
##########
@@ -705,6 +705,11 @@ class ChartDataExtrasSchema(Schema):
class ChartDataQueryObjectSchema(Schema):
+ applied_time_extras = fields.Dict(
+ description="A mapping of temporal extras that have been applied to
the query",
+ required=False,
+ example={"__time_range": "1 year ago : now"},
+ )
Review comment:
I tried creating a dedicated schema with named properties
(`__time_range` etc) and then adding a nested reference here, but that didn't
work, probably due to the double underscores. Leaving these as a `fields.Dict`
for now to get around the double underscore problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
