suddjian commented on a change in pull request #11325:
URL:
https://github.com/apache/incubator-superset/pull/11325#discussion_r507897107
##########
File path: superset/models/dashboard.py
##########
@@ -156,7 +156,7 @@ class Dashboard( # pylint:
disable=too-many-instance-attributes
]
def __repr__(self) -> str:
- return f"Dashboard<{self.slug or self.id}>"
+ return f"Dashboard<{self.id or self.slug}>"
Review comment:
shouldn't this be the other way round? Is this one of those lines you
didn't touch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
