suddjian commented on a change in pull request #11325:
URL:
https://github.com/apache/incubator-superset/pull/11325#discussion_r507897475
##########
File path: superset/models/dashboard.py
##########
@@ -156,7 +156,7 @@ class Dashboard( # pylint:
disable=too-many-instance-attributes
]
def __repr__(self) -> str:
- return f"Dashboard<{self.slug or self.id}>"
+ return f"Dashboard<{self.id or self.slug}>"
Review comment:
I guess if it's for the `__repr__` function it makes more sense to use
the id
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
