eschutho commented on pull request #10834: URL: https://github.com/apache/incubator-superset/pull/10834#issuecomment-712518343
Sounds great, @graceguo-supercat. The fixes here are mostly around the modal save, although there are a few changes to the label colors on the second save that may not have an effect on the overall scope if the user doesn't save afterward. The edit property modal changes still work, though. I know that there are larger usability issues here to address around the double save. I wasn't necessarily trying to address any of the dashboard save issues in this PR, but if you think it would be beneficial to address that issue here as well, I definitely can. Would that be your preference? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
