[GitHub] [incubator-superset] riahk opened a new pull request #11370: fix: add sort option to filters, sort chart list filter options

Wed, 21 Oct 2020 12:09:00 -0700 


riahk opened a new pull request #11370:
URL: https://github.com/apache/incubator-superset/pull/11370


   ### SUMMARY
   - [x] Add `sort` flag on `Filters` component, to be used with `fetchSelects` 
prop
   - [x] Sorts options alphabetically/ascending
   - [x] Add `sort` flag for dataset filter dropdown on chart list, sort viz 
type list
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="1203" alt="Screen Shot 2020-10-21 at 12 04 19 PM" 
src="https://user-images.githubusercontent.com/8216382/96770927-dc2e2a80-1395-11eb-8fec-7024eee7a818.png";>
   <img width="1205" alt="Screen Shot 2020-10-21 at 12 04 26 PM" 
src="https://user-images.githubusercontent.com/8216382/96770929-dcc6c100-1395-11eb-99a8-022758ae7965.png";>
   
   ### TEST PLAN
   - [x] 👀 chart list filter options are listed alphabetically
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to