eschutho commented on a change in pull request #11289:
URL:
https://github.com/apache/incubator-superset/pull/11289#discussion_r509742475
##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -241,9 +242,42 @@ export const DEFAULT_STYLES: PartialStylesConfig = {
}),
};
-const { ClearIndicator, DropdownIndicator, Option } = defaultComponents;
+const multiInputStyle = css`
+ padding: 0 6px;
+ vertical-align: middle;
+`;
-export const DEFAULT_COMPONENTS: SelectComponentsConfig<any> = {
+type SelectComponentsType = Omit<SelectComponentsConfig<any>, 'Input'> & {
+ Input: ComponentType<InputProps>;
+};
+
+// react-select is missing selectProps from their props type
+// so overwriting it here to avoid errors
+type InputProps = {
+ selectProps: {
+ isMulti: boolean;
+ value: {
+ length: number;
+ };
+ placeholder: string;
+ };
+ cx: (a: string | null, b: any, c: string) => string | void;
Review comment:
Most of these attribute types are pulled in from the existing type on
InputProps from `react-select` with the exception that I'm adding `selectProps`
which exists on the component, but the library doesn't have it present in the
types.. a bug on their part I think. Not sure how removing any attributes would
break anything down the road.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
