eschutho commented on a change in pull request #11289:
URL:
https://github.com/apache/incubator-superset/pull/11289#discussion_r510512576
##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -241,9 +242,42 @@ export const DEFAULT_STYLES: PartialStylesConfig = {
}),
};
-const { ClearIndicator, DropdownIndicator, Option } = defaultComponents;
+const multiInputStyle = css`
+ padding: 0 6px;
+ vertical-align: middle;
+`;
-export const DEFAULT_COMPONENTS: SelectComponentsConfig<any> = {
+type SelectComponentsType = Omit<SelectComponentsConfig<any>, 'Input'> & {
+ Input: ComponentType<InputProps>;
+};
+
+// react-select is missing selectProps from their props type
+// so overwriting it here to avoid errors
+type InputProps = {
+ selectProps: {
+ isMulti: boolean;
+ value: {
+ length: number;
+ };
+ placeholder: string;
+ };
+ cx: (a: string | null, b: any, c: string) => string | void;
Review comment:
Ah, those were exported. I missed them the first time around. thx. I am
admittedly still leveling up my typescript chops, so this sort of worked, but I
still had to declare some times for the selectProps properties below. Not sure
why they didn't import correctly off the interface. It could be because I'm
taking the placeholder of selectProps and assigning it to the placeholder on
the input and maybe the types aren't the same, but if you have any suggestions,
lmk!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
