nytai commented on a change in pull request #11370:
URL:
https://github.com/apache/incubator-superset/pull/11370#discussion_r512383468
##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -28,14 +28,24 @@ const createFetchResourceMethod = (method: string) => (
resource: string,
relation: string,
handleError: (error: Response) => void,
-) => async (filterValue = '', pageIndex?: number, pageSize?: number) => {
+) => async (
+ filterValue = '',
+ pageIndex?: number,
+ pageSize?: number,
+ sortValue?: string,
+ sortDirection = 'asc',
Review comment:
let's scrap this. I was wrong, the `related|distinct` endpoints don't
take `order_column` and `order_direction` params
https://github.com/apache/incubator-superset/blob/10a54b52ac522ff41bd45d17c5deb417dfa8a359/superset/views/base_api.py#L46
so this is doing nothing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
