[GitHub] [incubator-superset] ktmud opened a new pull request #11539: fix: hide extra blank space in dashboard chart menu

Tue, 03 Nov 2020 14:55:58 -0800 


ktmud opened a new pull request #11539:
URL: https://github.com/apache/incubator-superset/pull/11539


   ### SUMMARY
   
   Hide extra blank space in the "Force Refresh" link in dashboard chart's 
dropdown menu, while chart query is still running.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   <img 
src="https://user-images.githubusercontent.com/335541/98049168-03e4b000-1de4-11eb-9f98-0e1f5a5580c2.png";
 width="200">
   
   Not sure if it was by design originally, but it always kind of bothers me.
   
   #### After
   
   <img 
src="https://user-images.githubusercontent.com/335541/98049176-07783700-1de4-11eb-9d22-128b869fa081.png";
 width="200">
   
   ### TEST PLAN
   
   Manual
   
   1. Go to a dashboard with charts with very slow query
   2. Click on "Force Refresh"
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to