etr2460 commented on a change in pull request #11539:
URL:
https://github.com/apache/incubator-superset/pull/11539#discussion_r520709986
##########
File path: superset-frontend/package-lock.json
##########
@@ -20532,7 +20532,8 @@
},
"kind-of": {
"version": "6.0.2",
- "resolved": "",
+ "resolved": "https://registry.npmjs.org/kind-of/-/kind-of-6.0.2.tgz";,
Review comment:
are these changes intended?
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -146,12 +146,14 @@ class SliceHeaderControls extends React.PureComponent {
disabled={this.props.chartStatus === 'loading'}
>
{t('Force refresh')}
- <div
- className="refresh-tooltip"
- data-test="dashboard-slice-refresh-tooltip"
- >
- {refreshTooltip}
- </div>
+ {refreshTooltip && (
+ <div
+ className="refresh-tooltip"
+ data-test="dashboard-slice-refresh-tooltip"
Review comment:
seems like this could be really easy to add a unit test for since this
already has a `data-test` attribute. Might be worth adding a test for when the
dashboard is refreshing then the div isn't rendered
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
