rusackas commented on a change in pull request #11554:
URL:
https://github.com/apache/incubator-superset/pull/11554#discussion_r517674560
##########
File path: superset-frontend/src/common/components/index.tsx
##########
@@ -33,8 +33,10 @@ export {
DatePicker,
Dropdown,
Empty,
+ Input,
Modal,
Popover,
+ Select,
Review comment:
Are these Input/Select elements significantly different from a visual
perspective? We should consider restyling them as needed to look like the
SIP-34 design system, and eventually replacing the other disparate Input/Select
components with these ones for consistency. Probably not a rush, but I just
want to make sure we follow up on this stuff when we add new species :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
