[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11554: refactor: Replace react-bootstrap MenuItems with Antd Menu

Thu, 05 Nov 2020 08:18:40 -0800 


kgabryje commented on a change in pull request #11554:
URL: 
https://github.com/apache/incubator-superset/pull/11554#discussion_r518177335



##########
File path: superset-frontend/src/common/components/index.tsx
##########
@@ -33,8 +33,10 @@ export {
   DatePicker,
   Dropdown,
   Empty,
+  Input,
   Modal,
   Popover,
+  Select,

Review comment:
       The difference is not that significant. Still, when react-bootstrap 
input was next to Antd Select, it looked weird.
   Before:
   
![image](https://user-images.githubusercontent.com/15073128/98266566-c40bfd00-1f8a-11eb-91e5-20fd91d929d8.png)
   After:
   
![image](https://user-images.githubusercontent.com/15073128/98266051-1ef12480-1f8a-11eb-979d-6a50cf529e87.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to