[GitHub] [incubator-superset] ktmud opened a new pull request #11570: fix: minor style touch on dashboards

Wed, 04 Nov 2020 18:43:20 -0800 


ktmud opened a new pull request #11570:
URL: https://github.com/apache/incubator-superset/pull/11570


   ### SUMMARY
   
   A couple of small styling fixes for the dashboard page.
   
   1. Change tabs back to regular case: in general, user inputs should not be 
uppercase because if users really want to use uppercase, they can easily do 
that themself. Leaving uppercase labels to native UI elements also makes them 
more special and utility-like.
   2. Adjust the margins in filter labels. Currently the text is kind of all 
over the place. 
   3. Change the cursor for dashboard tabs in editing state from pointer 
(indicating a button) to text (indicating this is an input field).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   <img 
src="https://user-images.githubusercontent.com/335541/98190754-92ccf780-1ecc-11eb-8f17-a48bc68c99eb.png";
 width="400">
   
   #### After
   
   <img 
src="https://user-images.githubusercontent.com/335541/98190817-bdb74b80-1ecc-11eb-96e3-4fe04d4823a5.png";
 width="400">
   
   ##### On Explore page:
   
   
![Snip20201104_28](https://user-images.githubusercontent.com/335541/98190924-efc8ad80-1ecc-11eb-8790-17fd213a22e4.png)
   
   
   ### TEST PLAN
   
   Manually check the style works.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc @rusackas @kgabryje 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to