mistercrunch commented on a change in pull request #11617:
URL:
https://github.com/apache/incubator-superset/pull/11617#discussion_r520029907
##########
File path: superset/jinja_context.py
##########
@@ -338,6 +347,8 @@ def get_template_processor(
template_processor = template_processors.get(
database.backend, BaseTemplateProcessor
)
+ elif
feature_flag_manager.is_feature_enabled("CHEVRON_TEMPLATE_PROCESSING"):
Review comment:
Right, clearly there's some cleanup to be done here, but also need to
maintain backward compatibility. I think that's the easy portion of this PR,
the real question is around the viability of `chevron` as a secure templating
backend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
