villebro commented on a change in pull request #11617:
URL:
https://github.com/apache/incubator-superset/pull/11617#discussion_r520370632
##########
File path: superset/jinja_context.py
##########
@@ -338,6 +347,8 @@ def get_template_processor(
template_processor = template_processors.get(
database.backend, BaseTemplateProcessor
)
+ elif
feature_flag_manager.is_feature_enabled("CHEVRON_TEMPLATE_PROCESSING"):
Review comment:
I would propose calling the feature flag `TEMPLATE_PROCESSING`, and then
adding a config parameter `TEMPLATE_PROCESSOR: Optional[TemplateProcessorType]
= TemplateProcessorType.CHEVRON`. Similar to how other feature flagged options
do (see e.g. `THUMBNAIL_SELENIUM_USER`, `THUMBNAIL_CACHE_CONFIG` etc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
