kgabryje opened a new pull request #11640:
URL: https://github.com/apache/incubator-superset/pull/11640


   ### SUMMARY
   When user edited a chart title through Edit properties modal, the title of 
the chart didn't update, even though it was correctly saved.
   When user edits chart properties on Explore view, the changes are saved 
locally, but there is no request to API until the user clicks "Save" button. 
Modals on other views (ChartList and ChartTable) work as before.
   On the gif you can see that no request is being made when editing chart 
title on Explore view until "save" button is clicked.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   ![ezgif com-gif-maker 
(3)](https://user-images.githubusercontent.com/15073128/98676856-731a5100-235c-11eb-9aac-f62dcb5d5860.gif)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: 
https://github.com/apache/incubator-superset/issues/11623
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC: @junlincc 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to