graceguo-supercat commented on pull request #11640: URL: https://github.com/apache/incubator-superset/pull/11640#issuecomment-726283378
we made 2 API calls to save chart properties change: <img width="1182" alt="Screen Shot 2020-11-12 at 11 08 58 AM" src="https://user-images.githubusercontent.com/27990562/98984798-8867ba80-24d7-11eb-9b76-f265ad4974c5.png";> Is it really necessary to call 2 different APIs? Dashboard Properties modal did similar work, in my opinion it's a bad design and caused many issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/27990562/98984798-8867ba80-24d7-11eb-9b76-f265ad4974c5.png"](https://user-images.githubusercontent.com/27990562/98984798-8867ba80-24d7-11eb-9b76-f265ad4974c5.png"){kind=link}