villebro commented on a change in pull request #11731:
URL:
https://github.com/apache/incubator-superset/pull/11731#discussion_r525863217
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1333,7 +1335,9 @@ def fetch_metadata(self, commit: bool = True) ->
MetadataResult:
db_engine_spec = self.database.db_engine_spec
old_columns = db.session.query(TableColumn).filter(TableColumn.table
== self)
- old_columns_by_name = {col.column_name: col for col in old_columns}
+ old_columns_by_name: Dict[str, TableColumn] = {
+ col.column_name: col for col in old_columns
+ }
Review comment:
Not sure if it's just my IDE, but PyCharm wasn't able to infer the type
without the explicit type hint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
