villebro commented on a change in pull request #11731:
URL:
https://github.com/apache/incubator-superset/pull/11731#discussion_r525865866
##########
File path: superset/connectors/sqla/views.py
##########
@@ -470,7 +474,7 @@ def post_add( # pylint: disable=arguments-differ
)
def post_update(self, item: "TableModelView") -> None:
- self.post_add(item, flash_message=False)
+ self.post_add(item, flash_message=False, fetch_metadata=False)
Review comment:
@dpgaspar do you know why we call `post_add` every time we `post_update`
the dataset? Previously we were calling `fetch_metadata` and
`create_table_permissions` every time we updated, but after this change we'll
only call `create_table_permissions`. Is this just to make sure any potentially
stale perms get synced?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
