kgabryje commented on a change in pull request #11709:
URL:
https://github.com/apache/incubator-superset/pull/11709#discussion_r527118368
##########
File path: superset-frontend/src/components/Menu/Menu.tsx
##########
@@ -134,6 +134,19 @@ const StyledHeader = styled.header`
display: flex;
align-items: center;
}
+
+ .ant-menu {
+ .ant-menu-item-group-title {
+ padding-bottom: ${({ theme }) => theme.gridUnit}px;
+ }
+ .ant-menu-item {
+ margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
+ }
+ .about-section {
+ margin: ${({ theme }) => theme.gridUnit}px 0
+ ${({ theme }) => theme.gridUnit * 2}px;
+ }
Review comment:
Those styles are needed not for any last child but specifically for
"About us" section. That section is a bit "hacked" as "Version" and "SHA" are
not defined as menu items - we don't want them to be clickable or highlighted
on hover. Because of that, default Antd styles from `Menu` were not applied
there and I added those styles to make it look nicer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
