ktmud commented on a change in pull request #11709:
URL:
https://github.com/apache/incubator-superset/pull/11709#discussion_r527195513
##########
File path: superset-frontend/src/components/Menu/Menu.tsx
##########
@@ -134,6 +134,19 @@ const StyledHeader = styled.header`
display: flex;
align-items: center;
}
+
+ .ant-menu {
+ .ant-menu-item-group-title {
+ padding-bottom: ${({ theme }) => theme.gridUnit}px;
+ }
+ .ant-menu-item {
+ margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
+ }
+ .about-section {
+ margin: ${({ theme }) => theme.gridUnit}px 0
+ ${({ theme }) => theme.gridUnit * 2}px;
+ }
Review comment:
In that case, we may still generalize it something like `MetaMenuItem`
in case this pattern is used elsewhere. But let's not over-optimize for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
