dpgaspar commented on a change in pull request #11714:
URL:
https://github.com/apache/incubator-superset/pull/11714#discussion_r527529490
##########
File path: superset/views/core.py
##########
@@ -731,6 +734,7 @@ def explore( # pylint:
disable=too-many-locals,too-many-return-statements
)
@api
+ @event_logger.log_this
Review comment:
The order of the decorators here seem random
##########
File path: superset/views/core.py
##########
@@ -2741,6 +2766,7 @@ def sqllab(self) -> FlaskResponse:
@has_access
@expose("/sqllab/history/", methods=["GET"])
+ @event_logger.log_this
Review comment:
again decorators with random order
##########
File path: superset/utils/log.py
##########
@@ -69,7 +89,8 @@ def log_context(self, action: str) -> Iterator[Callable[...,
None]]:
except (TypeError, ValueError):
slice_id = 0
- self.stats_logger.incr(action)
+ if log_to_statsd:
+ self.stats_logger.incr(action)
Review comment:
+1 to eventually push to completely remove it
##########
File path: superset/views/core.py
##########
@@ -2113,6 +2133,7 @@ def stop_query(self) -> FlaskResponse:
return self.json_response("OK")
@has_access_api
+ @event_logger.log_this
Review comment:
duplicate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
