dpgaspar commented on a change in pull request #11714:
URL:
https://github.com/apache/incubator-superset/pull/11714#discussion_r527534885
##########
File path: superset/dashboards/api.py
##########
@@ -205,6 +206,7 @@ def __init__(self) -> None:
@protect()
@safe
@statsd_metrics
+ @event_logger.log_this
Review comment:
`log_this` depends on the DB but runs before safe, so if something fails
a non handled crash will surface to the user
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
