kgabryje commented on a change in pull request #11737:
URL:
https://github.com/apache/incubator-superset/pull/11737#discussion_r527690718
##########
File path:
superset-frontend/src/explore/components/AdhocMetricEditPopoverTitle.jsx
##########
@@ -18,7 +18,8 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
-import { FormControl, OverlayTrigger, Tooltip } from 'react-bootstrap';
+import { FormControl } from 'react-bootstrap';
+import Tooltip from 'src/common/components/Tooltip';
Review comment:
Hmm, I see that we have mixed export styles in `common/components` - we
use both default and named exports. I also prefer named exports, so I
refactored Tooltip and it's usages, but I think that we should do the same for
other components in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
