kgabryje commented on a change in pull request #11737:
URL:
https://github.com/apache/incubator-superset/pull/11737#discussion_r527728835
##########
File path: superset-frontend/src/SqlLab/components/ColumnElement.tsx
##########
@@ -18,13 +18,47 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
+import { ClassNames } from '@emotion/core';
+import { styled, useTheme } from '@superset-ui/core';
-import { OverlayTrigger, Tooltip } from 'react-bootstrap';
+import { Tooltip } from 'src/common/components/Tooltip';
const propTypes = {
column: PropTypes.object.isRequired,
};
+const StyledTooltip = props => {
+ const theme = useTheme();
+ return (
+ <ClassNames>
Review comment:
We can't simply wrap Tooltip in `styled` - here's an explanation
https://stackoverflow.com/a/63500556/6881179.
I used Emotion's `ClassNames` instead of mounting a tooltip as a child of
trigger node, because I didn't like the idea of Tooltip being a child of span.
This feels cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
