[GitHub] [incubator-superset] agatapst opened a new pull request #11780: refactor: Replace SqlLab components' styles using Emotion & theme variables

[GitBox]

agatapst opened a new pull request #11780:
URL: https://github.com/apache/incubator-superset/pull/11780


   ### SUMMARY
   Refactor covers changes in SqlLab components with inline or less classname 
styles implementation. They were replaced with Emotion based components using 
Superset UI Theme variables in some cases. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   In all cases, only one thing has slightly changed regarding UI. Template 
Parameters modal's border color was changed from inline style color `#CCC` to 
light grey color provided in Theme. 
   Before:
   <img width="600" alt="#ccc" 
src="https://user-images.githubusercontent.com/47450693/99983101-bc7e8d80-2dab-11eb-948c-32f2e719e7a9.png";>
   
   Now: 
   <img width="600" alt="lightgrey" 
src="https://user-images.githubusercontent.com/47450693/99983329-02d3ec80-2dac-11eb-83be-abbfa5fe7452.png";>
   
   ### TEST PLAN
   Verify manually if SqlLab tab looks correct. 
   Changes concern following SqlLab components:
   Query Search, QueryTable, Query Schedule Button, Sql Editor Left bar and 
Template params editor. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org