rusackas commented on a change in pull request #11780:
URL:
https://github.com/apache/incubator-superset/pull/11780#discussion_r529114515
##########
File path: superset-frontend/src/SqlLab/components/QueryTable.jsx
##########
@@ -47,6 +47,18 @@ const defaultProps = {
onDbClicked: () => {},
};
+const StyledButtonContainer = styled.div`
+ width: 100px;
+`;
+
+const StyledLinksContainer = styled.div`
+ width: 75px;
+`;
+
+const StyledProgressBar = styled(ProgressBar)`
+ width: 75px;
Review comment:
While I'm confident from the code that what you did here will look
perfect, have you had a chance to verify this visually? The reason I ask is not
fear of a regression, but instead, I'm wondering if we even _need_ this styling
at all, or if the ProgressBar looks goofy without it.
For all three of these specified pixel widths, I'm not sure from looking at
the code what they're based on, or if they're really needed at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
