[GitHub] [incubator-superset] agatapst commented on a change in pull request #11780: refactor: Replace SqlLab components' styles using Emotion & theme variables

Tue, 24 Nov 2020 02:37:57 -0800 


agatapst commented on a change in pull request #11780:
URL: 
https://github.com/apache/incubator-superset/pull/11780#discussion_r529430255



##########
File path: superset-frontend/src/SqlLab/components/QueryTable.jsx
##########
@@ -47,6 +47,18 @@ const defaultProps = {
   onDbClicked: () => {},
 };
 
+const StyledButtonContainer = styled.div`
+  width: 100px;
+`;
+
+const StyledLinksContainer = styled.div`
+  width: 75px;
+`;
+
+const StyledProgressBar = styled(ProgressBar)`
+  width: 75px;

Review comment:
       Yes, there is a small change regarding UI - but imo not that 
significant, so given your comment below, it's worth removing these styles. 
Just in case, there is screenshot:
   with styles:
   
![image](https://user-images.githubusercontent.com/47450693/100081367-3748b680-2e47-11eb-9233-a2a01a632c9a.png)
   
   without styles:
   
![image](https://user-images.githubusercontent.com/47450693/100081352-344dc600-2e47-11eb-9126-6c1c200f3164.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to