ktmud commented on a change in pull request #11781:
URL:
https://github.com/apache/incubator-superset/pull/11781#discussion_r529817675
##########
File path: superset/config.py
##########
@@ -300,6 +300,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
DEFAULT_FEATURE_FLAGS: Dict[str, bool] = {
# Experimental feature introducing a client (browser) cache
"CLIENT_CACHE": False,
+ "ENABLE_DATASET_SOURCE_EDIT": True,
Review comment:
nit: Can we name this `DISABLE_DATASET_SOURCE_EDIT` and set it to
`False` by default? IMO every feature flag should be false by default, similar
to every A/B testing experience starts with a current base (new feature being
disabled) vs a new feature. We set the default of a feature flag to `true` only
when we put an A/B testing full-on, but they will be cleaned up eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
