graceguo-supercat edited a comment on pull request #11781: URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733920959
We need extra protection here because current change in Source Tab is confusing. **_It looks like to build a chart from different dataset, but actually it is to change the tables used by that dataset_**. If i created a dataset and share this dataset with others, I would allow other ppl add metrics or columns, but I would not want someone change the tables for my dataset. If needed you should create (or copy) your own dataset. Edit metrics and columns is different: it won't change the tables that defines this dataset. When user edit Metrics or Columns, they can find error and recover it right away. (Remove existed metrics and columns are dangerous too, you might remove something other ppl use). Edit Metrics and Calculated Columns also happens pretty often, so we don't want to add extra click for this operation. @ktmud and @Steejay Your design looks good, but please note only `Source` tab has ReadOnly control. Both header and footer section, are shared with other tabs. We can do hide and show for Padlock if user is in other tab, but I just want to emphasis **"Source" tab** need extra careful protection. I do not want to share Padlock with other tabs with intention. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
