keehl1213 commented on issue #11810:
URL: 
https://github.com/apache/incubator-superset/issues/11810#issuecomment-734015404


   > As displayed in the config comments 
(https://github.com/apache/incubator-superset/blob/master/superset/config.py#L918),
 you need to pass in `"None"` and not `None` to set the samesite attribute to 
"None". This is an unfortunate naming collision between Python and web 
standards...
   > 
   > Note I believe you also must set `SESSION_COOKIE_HTTPONLY` to True to set 
any of the samesite options as otherwise a malicious site could grab your 
cookie through JS and impersonate the user
   
   It doesn't work either with `SESSION_COOKIE_SAMESITE = "None"`.  Actually, 
the `samesite` never showed up once in `set-cookie`, whatever the value is 
`"Lax"`, `"Strict"`, `"None"` or `None`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to