eschutho commented on pull request #11820: URL: https://github.com/apache/incubator-superset/pull/11820#issuecomment-736851362
Thanks all for this feedback. After seeing that we have a few other existing wrappers `makeApi` and also the `hooks.ts` file for the CRUD views on top of SupersetClient, I think it'll be good to take a step back and look at all of our existing async wrappers and see what we want to continue to use. I was hoping that this could be a start at abstraction, but realize now that it might be diverging from some existing patterns. Let's plan to sync back on this after 1.0 is completed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
