villebro commented on pull request #11880: URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737460449
@robdiciuccio here's my take on the topic: - The multiple queries feature was added prior to the SIP process, but was only implemented on the backend - the necessary frontend changes weren't done. - The `api/v1/chart/data` already supports multiple queries, so no backend changes are necessary. - `superset/explore_json` and `viz.py` don't need to be changed, as they won't be supporting multiple queries. - Based on my understanding of the async PR, `QueryContext` gets a `cache_key` of it's own in `QueryContext.cache_key()`, and that can handle multiple queries. I'm uncertain if we want to cache only the `QueryObject` or both the `QueryObject` and `QueryContext` going forward, but both can be done. - There are a few things that still need to be addressed. For instance, the "View Results" and "View Query" features currently only support showing the query/results for a single query object. But AFAIK this isn't a major problem and can be addressed later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
