simchaNielsen commented on a change in pull request #11880:
URL:
https://github.com/apache/incubator-superset/pull/11880#discussion_r534780130
##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -185,14 +179,14 @@ class Chart extends React.PureComponent {
errorMessage,
onQuery,
refreshOverlayVisible,
+ queriesResponse,
} = this.props;
const isLoading = chartStatus === 'loading';
-
const isFaded = refreshOverlayVisible && !errorMessage;
this.renderContainerStartTime = Logger.getTimestamp();
if (chartStatus === 'failed') {
- return this.renderErrorMessage();
+ return queriesResponse.map(item => this.renderErrorMessage(item));
Review comment:
Hi good catch, I didn't check it properly for all kinds of charts
(new/old). I pushed now some small fix for it. Basically for now for new api
there is no case that it returns more than 1 error per request even for multi
queries, but if it will return we can support it, but for now it will be only
one row.
Attaching screenshots after my fix for charts:
1. Old charts:
2. New charts:
3. New charts with multiqueries (looks the same):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
