bkyryliuk commented on pull request #11868: URL: https://github.com/apache/incubator-superset/pull/11868#issuecomment-737537190
> This feels slightly specific to Hive. Could we move this logic into `BaseEngineSpec` by introducing a `def is_dml(statement)` or `def is_readonly(statement)`, and let the specific db implementation do the parsing? Sounds good to me, will refactor it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
