rusackas commented on a change in pull request #11854:
URL:
https://github.com/apache/incubator-superset/pull/11854#discussion_r536301029
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
Review comment:
Maybe there's a compromise, setting the `EXPLORE_GUTTER_HEIGHT` and
`EXPLORE_GUTTER_MARGIN` constants to the number of gridUnits, and then using
that as the multiplier - in this case they'd both be set to `1`, I suppose.
Which then raises the question of whether we need two consts or just use one
unified gutter size const.
If this is all too much trouble or ruins the readability, maybe we can just
change them both to `4` so they at least match the current world layout grid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
