junlincc edited a comment on pull request #11854: URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738853449
 tested in Mozilla today. - previous cosmetic issues are addressed ✅ - white background added to the table ✅ - empty state ✅ remaining issues: 1. typing text in search seems there's delay, see gif - should address separately, confirmed that it's happening currently in master, not related to this PR 2. glitch when resizing - users will not likely resize too fast, not critical, should merge and address later 3. big data sample crash - already assigned separate issue, and prioritized, it should be fixed soon. @etr2460 @rusackas any objections? > @mistercrunch I noticed that on current master, we send a request for samples not only when chart data changes, but every time we open a modal. Should we consider refetching samples only when filters change as a separate feature? if this behavior is not new, we should address it separately. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
