suddjian commented on a change in pull request #11880:
URL:
https://github.com/apache/incubator-superset/pull/11880#discussion_r537818342
##########
File path: superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts
##########
@@ -132,12 +132,12 @@ export const selectIndicatorsForChart = (
// for now we only need to know which columns are compatible/incompatible,
// so grab the columns from the applied/rejected filters
const appliedColumns: Set<string> = new Set(
- (chart?.queryResponse?.applied_filters || []).map(
+ (chart?.queriesResponse?.[0]?.applied_filters || []).map(
Review comment:
I implemented this logic. The goal of these two lines is to get a set of
all the filters that were applied on a chart, and the filters that were
rejected (due to the column not existing in the dataset), in order to display
them in the filter badge.
If a chart makes multiple queries, it would probably be more correct to add
the `applied_filters` and `rejected_filters` from each of the queries, instead
of just the first one. But that really depends on how dashboard filters works
with multiple queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
