graceguo-supercat commented on a change in pull request #11970:
URL:
https://github.com/apache/incubator-superset/pull/11970#discussion_r539029934
##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.jsx
##########
@@ -139,6 +139,10 @@ class ControlPanelsContainer extends React.Component {
controls[s].validationErrors.length > 0,
),
);
+ if (exploreState.dataset_health_check_message) {
Review comment:
i can populate warning message from here, or from
`superset-ui-chart-controls`:
https://github.com/apache-superset/superset-ui/blob/1f8a700b953efbed81d2c9970b514d7fe031ad2e/packages/superset-ui-chart-controls/src/shared-controls/index.tsx#L166
but it will need to create another PR in another code base.@ktmud do you
have preference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
