ktmud commented on a change in pull request #11970:
URL: 
https://github.com/apache/incubator-superset/pull/11970#discussion_r539031961



##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.jsx
##########
@@ -139,6 +139,10 @@ class ControlPanelsContainer extends React.Component {
           controls[s].validationErrors.length > 0,
       ),
     );
+    if (exploreState.dataset_health_check_message) {

Review comment:
       This component `ControlPanelsContainer` is generic and should stay 
generic. It should not contain logics related to any specific control field.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to