suddjian commented on a change in pull request #11814: URL: https://github.com/apache/incubator-superset/pull/11814#discussion_r539737947
########## File path: superset-frontend/src/dashboard/components/nativeFilters/ColumnSelect.tsx ########## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React, { useCallback } from 'react'; +import { FormInstance } from 'antd/lib/form'; +import { SupersetClient, t } from '@superset-ui/core'; +import { useChangeEffect } from 'src/common/hooks/useChangeEffect'; +import { AsyncSelect } from 'src/components/Select'; +import { useToasts } from 'src/messageToasts/enhancers/withToasts'; +import getClientErrorObject from 'src/utils/getClientErrorObject'; +import { NativeFiltersForm } from './types'; + +type ColumnSelectValue = { + value: string; + label: string; +}; + +interface ColumnSelectProps { + form: FormInstance<NativeFiltersForm>; + filterId: string; + datasetId?: number | null | undefined; + value?: ColumnSelectValue | null; + onChange?: (value: ColumnSelectValue | null) => void; +} + +/** Special purpose AsyncSelect that selects a column from a dataset */ +// eslint-disable-next-line import/prefer-default-export +export function ColumnSelect({ Review comment: I think most people prefer named exports. Looking into it now, it looks like this rule is actually already disabled globally, but re-enabled by a second `.eslintrc` file specific to the dashboard app... I'll leave this comment here for now, and revisit the second eslint config another time. We should really have one consistent style throughout the frontend. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
