michael-s-molina opened a new pull request #12059: URL: https://github.com/apache/incubator-superset/pull/12059
### SUMMARY This PR fix all [exhaustive-deps](https://github.com/facebook/react/issues/14920) lint warnings. With this PR and also #12010 we'll have a code base with no lint warnings. The most part of this PR changes useEffect dependencies so it's critical that we do a lot of testing because if one dependency keeps changing the interface will keep rendering. We have some functions as dependencies and we need to make sure that they don’t change if not needed using techniques like useCallback. I already did a lot of testing but since I don't know all the functionalities yet we need more developers involved in the review process. ### TEST PLAN Assuming that the automatic tests already covered the majority of use cases, the basic idea here would be to review the code and test the affected modules simulating different user interactions. @rusackas As soon as you merge #12010 I can update this PR with the latest changes. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
